From: Claudio Cambra <claudio.cambra@nextcloud.com>
Date: Fri, 24 Jan 2025 04:14:30 +0000 (+0800)
Subject: shell_integration/macOS/FileProviderUIExt: Enforce item metadata being valid when... 
X-Git-Tag: archive/raspbian/3.16.7-1_deb13u1+rpi1~1^2~12^2~2^2~79^2~1
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/success/%22http:/www.example.com/cgi/success?a=commitdiff_plain;h=5dac5dfbf8198f3218f5f48ff9739e0c3ea240fa;p=nextcloud-desktop.git

shell_integration/macOS/FileProviderUIExt: Enforce item metadata being valid when fetching shares

Signed-off-by: Claudio Cambra <claudio.cambra@nextcloud.com>
---

diff --git a/shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareTableViewDataSource.swift b/shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareTableViewDataSource.swift
index 4fcea0652..d5e8ae58a 100644
--- a/shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareTableViewDataSource.swift
+++ b/shell_integration/MacOSX/NextcloudIntegration/FileProviderUIExt/Sharing/ShareTableViewDataSource.swift
@@ -30,7 +30,6 @@ class ShareTableViewDataSource: NSObject, NSTableViewDataSource, NSTableViewDele
         }
     }
     var capabilities: Capabilities?
-    var itemMetadata: NKFile?
 
     private(set) var itemURL: URL?
     private(set) var itemServerRelativePath: String?
@@ -117,10 +116,13 @@ class ShareTableViewDataSource: NSObject, NSTableViewDataSource, NSTableViewDele
                 presentError("Account data is unavailable, cannot reload data!")
                 return
             }
-            itemMetadata = await fetchItemMetadata(
+            guard let itemMetadata = await fetchItemMetadata(
                 itemRelativePath: serverPathString, account: account, kit: kit
-            )
-            guard itemMetadata?.permissions.contains("R") == true else {
+            ) else {
+                presentError("Unable to retrieve file metadata...")
+                return
+            }
+            guard itemMetadata.permissions.contains("R") == true else {
                 presentError("This file cannot be shared.")
                 return
             }